Thank you for your pull request. After careful consideration, we believe the proposed approach of mutating the player's sytyleConfig is not desirable:

• changes will not be taken into account by the player (player events will not be triggered)
• the scaling mode is a property of the PlayerView, not the Player
• React Native doesn't allow UI side-effects in @ReactMethod, UIManager has to be used instead.

Here follows our recommendation to implement PlayerView's ScalingMode. As the scaling mode property is similar to the fullscreen one, we have used it as an example for each step.

1. Add a scalingMode parameter to the PlayerView function and PlayerViewProps

   • bitmovin-player-react-native/src/components/PlayerView/index.tsx

     Lines 87 to 93 in a726523

     	export function PlayerView({
     	style,
     	player,
     	fullscreenHandler,
     	customMessageHandler,
     	isFullscreenRequested = false,
     	...props

2. Add a useEffect block dispatching a new setScalingMode command at the end of the PlayerView function (after and similarly to setFullscreen)

   • bitmovin-player-react-native/src/components/PlayerView/index.tsx

     Lines 165 to 170 in a726523

     	useEffect(() => {
     	const node = findNodeHandle(nativeView.current);
     	if (node) {
     	dispatch('setFullscreen', node, isFullscreenRequested);
     	}
     	}, [isFullscreenRequested, nativeView]);

3. Update the Kotlin and Swift code to handle this new message in RNPlayerViewManager (similar to the setFullscreen method)
   • call view.playerView.setScalingMode in the setScalingMode implementation
   • Kotlin:

     • bitmovin-player-react-native/android/src/main/java/com/bitmovin/player/reactnative/RNPlayerViewManager.kt

       Lines 169 to 173 in a726523

       	Commands.SET_FULLSCREEN -> {
       	args?.getBoolean(1)?.let { isFullscreen ->
       	setFullscreen(view, isFullscreen)
       	}
       	}

     • bitmovin-player-react-native/android/src/main/java/com/bitmovin/player/reactnative/RNPlayerViewManager.kt

       Lines 185 to 197 in a726523

       	private fun setFullscreen(view: RNPlayerView, isFullscreen: Boolean) {
       	if (view.playerView?.isFullscreen == isFullscreen) return
       	Handler(Looper.getMainLooper()).post {
       	with(view.playerView ?: return@post) {
       	if (isFullscreen) {
       	enterFullscreen()
       	} else {
       	exitFullscreen()
       	}
       	}
       	}
       	}

   • Swift:

     • bitmovin-player-react-native/ios/RNPlayerViewManager.m

       Lines 65 to 68 in a726523

       	RCT_EXTERN_METHOD(attachPlayer:(nonnull NSNumber *)viewId playerId:(NSString *)playerId playerConfig:(nullable NSDictionary *)playerConfig)
       	RCT_EXTERN_METHOD(attachFullscreenBridge:(nonnull NSNumber *)viewId fullscreenBridgeId:(NSString *)fullscreenBridgeId)
       	RCT_EXTERN_METHOD(setCustomMessageHandlerBridgeId:(nonnull NSNumber *)viewId customMessageHandlerBridgeId:(NSString *)fullscreenBridgeId)
       	RCT_EXTERN_METHOD(setFullscreen:(nonnull NSNumber *)viewId isFullscreen:(BOOL)isFullscreen)

     • bitmovin-player-react-native/ios/RNPlayerViewManager.swift

       Lines 74 to 94 in a726523

       	@objc func setFullscreen(_ viewId: NSNumber, isFullscreen: Bool) {
       	bridge.uiManager.addUIBlock { [weak self] _, views in
       	guard
       	let self,
       	let view = views?[viewId] as? RNPlayerView
       	else {
       	return
       	}
       	guard let playerView = view.playerView else {
       	return
       	}
       	guard playerView.isFullscreen != isFullscreen else {
       	return
       	}
       	if isFullscreen {
       	playerView.enterFullscreen()
       	} else {
       	playerView.exitFullscreen()
       	}
       	}
       	}

Looks good! Thanks for the improvements. I'll let @rolandkakonyi review the Swift side.

Nice job @jonathanm-tkf!

Please see my comments.